-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first attempt at modularizing #131
Conversation
Add test case for missing error code addition
Update test for changed data
* Update failing test to fixed with new sphericalmercator * Test appveyor on node 4.4.2 * Remove node v4 test on windows
bz = data[0].z; | ||
bx = data[0].x; | ||
by = data[0].y; | ||
source.getTile(bz, bx, by, sourceGet); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yhahn - Trying to work out a way to not use source.getTile
again, and use what we've already loaded here: https://github.com/mapbox/tilelive-vector/pull/131/files#diff-6d11f931df6358ebec2a997c99b90d66R95
^ This is faux-working :( - this typo is causing this to simply repeat: Line 126 in ce14e1a
|
Closing this to work on one pr to master #127 |
@yhahn I jumped back on this. Could I borrow your 👀 + 👂 to talk about how to implement most effectively?